mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <...@twitter.com.INVALID>
Subject Re: [Style Proposal] Disallow Capture by Constant Reference to temporary
Date Mon, 30 Mar 2015 19:15:06 GMT
I am a +1 on this too. We had a similar bug long time ago when we changed
the return value of Try::get() to be const ref.

On Mon, Mar 30, 2015 at 11:52 AM, Niklas Nielsen <niklas@mesosphere.io>
wrote:

> Big +1; You could also mention the recent bug in the Two fold
> authentication patch that you guys discovered with this bug.
>
> Niklas
>
> On 30 March 2015 at 10:49, Joris Van Remoortere <joris@mesosphere.io>
> wrote:
>
> > I would like to propose we disallow capturing temporaries using a
> constant
> > reference:
> > const T& val = f();
> >
> > *The reasons, and examples for this are outlined in the proposal here:*
> > [Review Board]: https://reviews.apache.org/r/32630/
> > [original markdown version]:
> > https://gist.github.com/jmlvanre/8a3de53ae88c2d19b375
> >
> >
> > Please feel free to comment here on the dev-list, though I also urge you
> to
> > comment on the Review Request as putting proposal markdowns on RB is
> > something new we're trying!
> >
> > Joris
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message