mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 32630: Add style change proposal for constant reference to temporaries.
Date Mon, 30 Mar 2015 18:22:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32630/#review78229
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32630]

All tests passed.

- Mesos ReviewBot


On March 30, 2015, 5:47 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32630/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 5:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and switched to 'mcypark'.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ben suggested we start pushing proposal markdowns to the repo, so they can go through
a nice review process.
> This proposal is to augment the style guide to disallow capturing temporaries by reference.
> 
> 
> Diffs
> -----
> 
>   docs/proposals/style/const_ref_to_temporary.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32630/diff/
> 
> 
> Testing
> -------
> 
> The 'output' in the proposal shows the problem.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message