mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 32346: Added failure semantics for http::Pipe::Writer.
Date Wed, 25 Mar 2015 22:12:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32346/#review77802
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/32346/#comment126081>

    Indent.



3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/32346/#comment126097>

    either end of the pipe is closed or failed!


- Jie Yu


On March 20, 2015, 11:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32346/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2438
>     https://issues.apache.org/jira/browse/MESOS-2438
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Pipe writer needs to be able to fail the reader when it cannot complete the pipe.
> 
> For example, if we are decoding a response and we cannot parse the body, we must ensure
the reader of the body sees a failure isntead of EOF. This was used in the subsequent patches
in this chain.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 2b366986b1f617e95bda94e07f2a0e532f5626f6

>   3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef 
>   3rdparty/libprocess/src/tests/http_tests.cpp 17fb092a851e128c137152fdce57e9fb10a08bf7

> 
> Diff: https://reviews.apache.org/r/32346/diff/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message