mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 29336: Recover docker containers that launched in containers.
Date Wed, 25 Mar 2015 15:58:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29336/#review77740
-----------------------------------------------------------



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29336/#comment125937>

    Maybe use the "_" for the parameter, not the local variable? Then both local vars "containers"
and "executors" look the same in that regard.
    
    However, see the next issue, fixing which would cancel this one.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29336/#comment125939>

    This type/name scheme is hard to understand. How can Docker::Container* values be containers
and executors? 
    
    How about choosing different variable names that make this more clear? 
    
    It seems that
    
    containers -> logContainers
    executors -> executorContainers


- Bernd Mathiske


On Jan. 16, 2015, 5:37 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29336/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 5:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recover docker containers that launched in containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp b7bf54a 
>   src/slave/containerizer/docker.cpp 5f4b4ce 
> 
> Diff: https://reviews.apache.org/r/29336/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message