mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 32105: Added << operator to stout.flags.
Date Wed, 25 Mar 2015 15:32:31 GMT


> On March 25, 2015, 3:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 597
> > <https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line597>
> >
> >     `s/<<"\""/<< "\""/` in both occurrences.

Also, do we have a rule that we can't use `char` literals? I think `'"'` is nicer than `"\""`.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77735
-----------------------------------------------------------


On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 12:25 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: Mesos-2323
>     https://issues.apache.org/jira/browse/Mesos-2323
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa

> 
> Diff: https://reviews.apache.org/r/32105/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message