mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 32337: Moved http::initialize from header to .cpp file.
Date Tue, 24 Mar 2015 20:34:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32337/#review77635
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On March 20, 2015, 11:51 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32337/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Many of the other http definitions are already moved to the .cpp file, this continues
that trend.
> 
> Moving them out makes the API a lot more readable from the scanning the header.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 2b366986b1f617e95bda94e07f2a0e532f5626f6

>   3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef 
> 
> Diff: https://reviews.apache.org/r/32337/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message