mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 32419: Used move assignment in the master's json endpoints.
Date Tue, 24 Mar 2015 19:13:17 GMT


> On March 24, 2015, 4:10 p.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, line 470
> > <https://reviews.apache.org/r/32419/diff/1/?file=903657#file903657line470>
> >
> >     Are you sure the outer `object` is not shadowed? Even if it's not, let us maybe
leave the original naming to avoid name collision and therefore confusion.

Yikes, good eye alex, this looks like a bug. I'll leave it as it was, or I'll update the names
to be "flags", "slaves", etc instead of "object", "array", etc.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77585
-----------------------------------------------------------


On March 24, 2015, 12:27 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32419/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 12:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-2353
>     https://issues.apache.org/jira/browse/MESOS-2353
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a simple attempt at improvement for MESOS-2353 in the interim of writing a more
comprehensive JSON benchmark.
> 
> Per the discussion on [r/31700](https://reviews.apache.org/r/31700/), moves here avoid
the very expensive copies of the large JSON objects so long as variant has move assignment
defined (or generated) and our objects have move generated.
> 
> It appears that variant has move assignment and our json classes can have move assignment
generated, so this should help.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp d3b7ca3727567ff252f978720f518ad0912e533b 
>   src/master/http.cpp e1a87d646e9690e39a9e84ae383622018ce80401 
> 
> Diff: https://reviews.apache.org/r/32419/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> No benchmarking performed given the analysis from Michael in [r/31700](https://reviews.apache.org/r/31700/).
I will also be trying this out on our large production clusters.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message