mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 31266: Added support for allocator modules.
Date Tue, 24 Mar 2015 05:55:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31266/#review77528
-----------------------------------------------------------



include/mesos/module/allocator.hpp
<https://reviews.apache.org/r/31266/#comment125626>

    `s/template<>/template <>/`



include/mesos/module/allocator.hpp
<https://reviews.apache.org/r/31266/#comment125634>

    I think this should be `create(_create) {}`.


- Michael Park


On March 23, 2015, 2:03 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31266/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2160
>     https://issues.apache.org/jira/browse/MESOS-2160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/allocator.hpp PRE-CREATION 
>   src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb 
>   src/module/manager.cpp 82a38f06e57d034650a6ac32fd73527b38cc97b8 
> 
> Diff: https://reviews.apache.org/r/31266/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.5, CentOS 7.0)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message