mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 28485: Provide a default bind() in Socket: any port localhost.
Date Thu, 19 Mar 2015 22:27:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28485/#review77122
-----------------------------------------------------------



3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/28485/#comment125013>

    Just curious, what's the IPv6 story here? Do you need a LOCALHOST_ANY_V6() in the future?



3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/28485/#comment125014>

    Returning `const Address&` to a static variable is problematic during teardown in
a multi-threaded enviornment because it'll be destructed while some thread might still be
using it.
    
    So please return a copy or use a pointer for the static local variable.


- Jie Yu


On March 19, 2015, 7:23 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28485/
> -----------------------------------------------------------
> 
> (Updated March 19, 2015, 7:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes it clearer when we intend to bind on a specific ip:port (socket.bind(node))
and when we just want to bind to any local port (socket.bind()).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp 0f0a577bd1b8940f71fc486dcb1be7aa55d57ab2

>   3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881

>   3rdparty/libprocess/src/process.cpp e7b029ba97e640c2102548c190ba62b30602f43d 
> 
> Diff: https://reviews.apache.org/r/28485/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message