mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 31028: Added slave run task hook tests.
Date Tue, 17 Mar 2015 22:03:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31028/#review76826
-----------------------------------------------------------

Ship it!



src/examples/test_hook_module.cpp
<https://reviews.apache.org/r/31028/#comment124486>

    s/MergeFrom/CopyFrom/


- Kapil Arya


On March 13, 2015, 7:04 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31028/
> -----------------------------------------------------------
> 
> (Updated March 13, 2015, 7:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 
> 
> Diff: https://reviews.apache.org/r/31028/diff/
> 
> 
> Testing
> -------
> 
> make check (with newly added VerifySlaveRunTaskHook test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message