mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Review Request 32108: Added manual make for readability training source code
Date Mon, 16 Mar 2015 16:09:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Repository: mesos


Description
-------

Readability source code now has a Makefile that is generated by bootstrap and configure. "cd
build/readability; make" compiles the sources in "readability/". No linking occurs. This is
just to ensure that we have syntactially correct and type-checked example files.

Slightly rearranged the content of naming_*.cpp and broke out an extra file for whitespace
issues.

Replaces:
https://reviews.apache.org/r/31990/
https://reviews.apache.org/r/31992/


Diffs
-----

  configure.ac 9b2d7f15f535aaaf85faf9b4f7af750f1dbdf472 
  readability/Makefile.am PRE-CREATION 
  readability/TODO PRE-CREATION 
  readability/naming_comments.cpp PRE-CREATION 
  readability/naming_review.cpp PRE-CREATION 
  readability/whitespace_comments.cpp PRE-CREATION 
  readability/whitespace_review.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32108/diff/


Testing
-------

cd build/readability; make


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message