mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31276: Added cgroup memory pressure listening tests.
Date Thu, 12 Mar 2015 18:06:39 GMT


> On March 11, 2015, 9:59 p.m., Jie Yu wrote:
> > src/tests/memory_test_helper.cpp, line 96
> > <https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line96>
> >
> >     Hum, this makes the page cache increasing depend on the memory allocation. Can
we simply construct a 4K buffer on the stack and perform write multiple times?
> >     
> >     Please do not use any ASSERT or EXPECT in the subprocess. Simply return Error
and let the top level function to deal with error conditions.
> 
> Chi Zhang wrote:
>     that'd take up 4k RSS memory the test writers don't know of and might not need for
other purposes? Let the test writers do fine control of things?

I am just suggesting a number. If you are concerned about the chunk size, use a smaller number,
say 128 bytes?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review76118
-----------------------------------------------------------


On March 10, 2015, 7:26 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31276/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Dominic Hamon, Ian Downes, and Jie Yu.
> 
> 
> Bugs: mesos-2136
>     https://issues.apache.org/jira/browse/mesos-2136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added cgroup memory pressure listening tests.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3059818231c46484039d179cd6916932eff6cd68 
>   src/tests/cgroups_tests.cpp 75c61aad80f894acb92a9752e8d1b6af70e5b9a6 
>   src/tests/memory_test_helper.hpp PRE-CREATION 
>   src/tests/memory_test_helper.cpp PRE-CREATION 
>   src/tests/memory_test_helper_child.hpp PRE-CREATION 
>   src/tests/memory_test_helper_main.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31276/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message