mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 31889: Updated Hooks to fix failure during master failover.
Date Wed, 11 Mar 2015 21:20:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/#review76115
-----------------------------------------------------------



include/mesos/hook.hpp
<https://reviews.apache.org/r/31889/#comment123537>

    Is this still relevant?



src/hook/manager.cpp
<https://reviews.apache.org/r/31889/#comment123538>

    s/varialbes/variables/



src/hook/manager.cpp
<https://reviews.apache.org/r/31889/#comment123569>

    s/append\/prepend/extend/



src/slave/containerizer/containerizer.cpp
<https://reviews.apache.org/r/31889/#comment123570>

    const Environment?



src/tests/hook_tests.cpp
<https://reviews.apache.org/r/31889/#comment123535>

    Why not launch this as a regular task?



src/tests/hook_tests.cpp
<https://reviews.apache.org/r/31889/#comment123534>

    const string


- Niklas Nielsen


On March 11, 2015, 12:38 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31889/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 12:38 p.m.)
> 
> 
> Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2463
>     https://issues.apache.org/jira/browse/MESOS-2463
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The ExecutorInfo is immutable, and so the environment decoration is deferred
> until containerizer launch. The new slaveExecutorHook simply notifies the hook
> module of a new executor being launched. The environment decorator hook for
> containerizer launch update it's environment variables as gathered from the hook
> modules.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef 
>   src/examples/test_hook_module.cpp 22212261053f2c10f7c4e5ae15aa3d4a2aa1c051 
>   src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1 
>   src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 
>   src/slave/containerizer/containerizer.cpp 33f8738fa229b42ebacfd75b762c977b33191b65

>   src/slave/slave.cpp 71ae84bbfcef208cc2ee603f3c8a79225e48a7d5 
>   src/tests/hook_tests.cpp b5d776a55b6b205394469c176ac6be6702c218f3 
> 
> Diff: https://reviews.apache.org/r/31889/diff/
> 
> 
> Testing
> -------
> 
> make check.  The master failover tests have not been performed yet.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message