mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 31905: Fixed protobuf comparisons by accounting for new fields.
Date Wed, 11 Mar 2015 00:33:08 GMT


> On March 10, 2015, 6:52 p.m., Dominic Hamon wrote:
> > is there a way to add tests for all of these so we don't regress again in future?

see above.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31905/#review75936
-----------------------------------------------------------


On March 10, 2015, 6:27 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31905/
> -----------------------------------------------------------
> 
> (Updated March 10, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joerg Schad, and Timothy Chen.
> 
> 
> Bugs: MESOS-2309
>     https://issues.apache.org/jira/browse/MESOS-2309
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When new fields were added to protobufs these operators were not updated. Fixed now.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 
> 
> Diff: https://reviews.apache.org/r/31905/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message