mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.
Date Tue, 10 Mar 2015 19:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
-----------------------------------------------------------

(Updated March 10, 2015, 7:30 p.m.)


Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone.


Changes
-------

Added onDiscard handler into the AuthenticatorSession as onAny wont get triggered by a discard
on a future.


Bugs: MESOS-2050
    https://issues.apache.org/jira/browse/MESOS-2050


Repository: mesos


Description
-------

The initial design and implementation of the authenticator module interface caused issues
and was not optimal for heavy lifting setup of external dependencies. By introducing a two
fold design, this has been decoupled from the authentication message processing. The new design
also gets us back on track to the goal of makeing SASL a soft dependency of mesos.


Diffs (updated)
-----

  include/mesos/authentication/authenticator.hpp f66217a 
  src/Makefile.am 3059818 
  src/authentication/cram_md5/authenticator.hpp c6f465f 
  src/authentication/cram_md5/authenticator.cpp PRE-CREATION 
  src/authentication/cram_md5/auxprop.hpp b894386 
  src/authentication/cram_md5/auxprop.cpp cf503a2 
  src/master/master.hpp 3c957ab 
  src/master/master.cpp dccd7c6 
  src/tests/cram_md5_authentication_tests.cpp 92a89c5 

Diff: https://reviews.apache.org/r/27760/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message