mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 31664: Added operator+= and operator+ for hashmap<SlaveID, Resources>.
Date Fri, 06 Mar 2015 23:28:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75571
-----------------------------------------------------------



src/common/resources.cpp
<https://reviews.apache.org/r/31664/#comment122759>

    This looks inconsistent with all of the other + operator implementations in this file,
no?


- Ben Mahler


On March 6, 2015, 6:46 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31664/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 6:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Convenience functions to help aggregate `hashmap<SlaveID, Resources>`. Used in
[r31665](https://reviews.apache.org/r/31665).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 
>   src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 
> 
> Diff: https://reviews.apache.org/r/31664/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message