mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave.
Date Fri, 06 Mar 2015 10:42:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31538/
-----------------------------------------------------------

(Updated March 6, 2015, 11:42 a.m.)


Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone.


Changes
-------

1. Added the framework and executor id in the log so debugging is made easier.
2. Shuts down the executor.
3. Removes validation from the `ExecutorDriver`.
4. Adds and indication to the comments, requesting to send a message explaining why the driver
is being shutdown.


Bugs: mesos-2291
    https://issues.apache.org/jira/browse/mesos-2291


Repository: mesos


Description
-------

Copies validations made to the messages exchanged between the slave and the `MesosExecutorDriver`
and performed in the executor driver to the slave. This is requiered since the new HTTP API
will deprecate the executor driver.


Diffs (updated)
-----

  src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 
  src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 

Diff: https://reviews.apache.org/r/31538/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message