mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 31664: Added operator+= and operator+ for hashmap<SlaveID, Resources>.
Date Fri, 06 Mar 2015 03:28:36 GMT


> On March 6, 2015, 3 a.m., Alexander Rukletsov wrote:
> > src/common/resources.cpp, line 26
> > <https://reviews.apache.org/r/31664/diff/2/?file=883420#file883420line26>
> >
> >     Why do we need this include?

We need the `inline std::size_t hash_value(const SlaveID& slaveId);` from it for `hashmap<SlaveID,
Resources>`.


> On March 6, 2015, 3 a.m., Alexander Rukletsov wrote:
> > src/common/resources.cpp, line 993
> > <https://reviews.apache.org/r/31664/diff/2/?file=883420#file883420line993>
> >
> >     We can let the compiler do the copy for us. There is an opinion, that this is
the preferred way: http://www.boost.org/doc/libs/1_57_0/libs/utility/operators.htm#symmetry

You're right. Will fix.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75452
-----------------------------------------------------------


On March 3, 2015, 8:27 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31664/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 8:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Convenience functions to help aggregate `hashmap<SlaveID, Resources>`. Used in
[r31665](https://reviews.apache.org/r/31665).
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 
>   src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 
> 
> Diff: https://reviews.apache.org/r/31664/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message