mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30841: Remove static strings and split process.cpp
Date Fri, 06 Mar 2015 02:12:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75449
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30841]

All tests passed.

- Mesos ReviewBot


On March 5, 2015, 7:39 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30841/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 7:39 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-1023
>     https://issues.apache.org/jira/browse/MESOS-1023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove static strings from process
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 8f96f49a386a70f14324d3a4744aa0b8bf3995f9 
>   3rdparty/libprocess/include/process/logging.hpp 122022343ccba433fecfc6ff548e8fa3d9bdca6b

>   3rdparty/libprocess/include/process/profiler.hpp c886d7e7e4effb10c661a4b7141686432255b370

>   3rdparty/libprocess/src/logging.cpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45 
>   3rdparty/libprocess/src/profiler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30841/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message