mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 31503: (2/6) Add the FlowId action
Date Thu, 05 Mar 2015 23:33:42 GMT


> On March 5, 2015, 9:57 p.m., Jie Yu wrote:
> > src/linux/routing/filter/action.hpp, line 77
> > <https://reviews.apache.org/r/31503/diff/2/?file=884497#file884497line77>
> >
> >     Add a space before the colon. Also, how about calling it `action::Flow` instead
of `action::FlowId`. It reads better since we have an `id()` member method:
> >     
> >     
> >     ```
> >     Try<bool> create(
> >         ...
> >         const action::Flow& flow)
> >     {
> >       xxx = flow.id();
> >     }
> >     ```

Since the action is supposed to set a flow id, "FlowId" is more meaningful than just "Flow".
Also, we don't call .id() in create(), we only call it in attach(), which is hidden from its
callers.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31503/#review75386
-----------------------------------------------------------


On March 4, 2015, 8:06 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31503/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 8:06 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Bugs: MESOS-2422
>     https://issues.apache.org/jira/browse/MESOS-2422
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduce a new action which saves the classid for a specified filter. Similar to the
u32 terminal action, it is not a real action defined by TC, it is just for setting a filter
attribute. The classid or flowid is used to match the fq_codel flows.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/filter/action.hpp 410c15a 
>   src/linux/routing/filter/arp.hpp fa0ea6f 
>   src/linux/routing/filter/arp.cpp bf19264 
>   src/linux/routing/filter/icmp.hpp 7b478c4 
>   src/linux/routing/filter/icmp.cpp 86bd67b 
>   src/linux/routing/filter/internal.hpp 8a6c0c0 
>   src/linux/routing/filter/ip.hpp 932ed4b 
>   src/linux/routing/filter/ip.cpp 922a732 
>   src/linux/routing/queueing/handle.hpp 2725d07 
>   src/tests/routing_tests.cpp 3cda6ab 
> 
> Diff: https://reviews.apache.org/r/31503/diff/
> 
> 
> Testing
> -------
> 
> Run the testcase.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message