mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31772: Fixed a bug in PosixDiskIsolator during slave recovery.
Date Thu, 05 Mar 2015 21:51:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31772/
-----------------------------------------------------------

(Updated March 5, 2015, 9:51 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Changes
-------

Review comments.


Bugs: MESOS-2452
    https://issues.apache.org/jira/browse/MESOS-2452


Repository: mesos


Description
-------

Fixed a bug in PosixDiskIsolator during slave recovery. See ticket for details.

Currently, RunState.directory points to the metadata directory. This would cause the PosixDiskIsolator
to report incorrect disk usages after slave recovery.

This patch kills 'directory' in RunState and calculate the 'directory' correctly in ExecutorRunState.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp ec4626f903d44c0911093ff763ef16ad27c418a9

  src/slave/state.hpp 0201e727585a86957c3116ee2fb36db8a4816010 
  src/slave/state.cpp 41f6c2c4bb68cca9569b528eda4fbc74d0cf934f 
  src/tests/disk_quota_tests.cpp 56d82eeb715080da40926f3661dbb7e66aeb3932 

Diff: https://reviews.apache.org/r/31772/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message