mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 30074: Added "max allowed age" to Slave state.json endpoint
Date Wed, 04 Mar 2015 23:11:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30074/#review75261
-----------------------------------------------------------


Patch looks great!

Reviews applied: [30074]

All tests passed.

- Mesos ReviewBot


On March 4, 2015, 4:21 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30074/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 4:21 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Bugs: mesos-2229
>     https://issues.apache.org/jira/browse/mesos-2229
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds and entry `max_allowed_age_secs` to the response of the `state.json` endpoint in
the slave. 
> 
> The max allowed age value is available only if it is set, which depends on the flag `--disk_watch_interval`
which by default runs every minute (So it will only be available after the first minute running).
> 
> Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the new entry.
> 
> 
> Diffs
> -----
> 
>   src/slave/metrics.hpp 0390461968112cac9ed84ec3cc23b264e8b4e9d7 
>   src/slave/metrics.cpp c32b4d8a1ff3bc5e5f5ca21eb78a036c9ea1a813 
>   src/slave/slave.hpp d476d850b195e917c5fcb5c82f69863b4f85e4b1 
>   src/slave/slave.cpp 2d52ea0c440fd530174b0e44a59c8ae68fa2616c 
>   src/tests/slave_tests.cpp 27b3410d25256951d685fa2a7f6d425b3e80709f 
> 
> Diff: https://reviews.apache.org/r/30074/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message