mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 30296: Deprecate /stats.json endpoint and supporting code.
Date Tue, 03 Mar 2015 18:23:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30296/#review74999
-----------------------------------------------------------



src/master/http.cpp
<https://reviews.apache.org/r/30296/#comment121900>

    Have we informed users about this API breaking change? If not, lets update the CHANGELOG
for 0.22.0 with this change (ask Niklas to cherry pick for 0.22.0) and send an email to dev/user
lists.



src/master/master.hpp
<https://reviews.apache.org/r/30296/#comment121901>

    lets not do s/memory/std/ in this review. we can do it in a sweep later.



src/slave/http.cpp
<https://reviews.apache.org/r/30296/#comment121902>

    ditto. have we informed?



src/tests/master_tests.cpp
<https://reviews.apache.org/r/30296/#comment121904>

    is there a test for verifying these metrics in the new metrics/snapshot endpoint? if not,
can we hit that endpoint instead in this test?



src/tests/slave_tests.cpp
<https://reviews.apache.org/r/30296/#comment121905>

    ditto.


- Vinod Kone


On March 2, 2015, 8:32 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30296/
> -----------------------------------------------------------
> 
> (Updated March 2, 2015, 8:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2058
>     https://issues.apache.org/jira/browse/MESOS-2058
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deprecate /stats.json endpoint and supporting code.
> 
> TO LAND AFTER 0.22 IS RELEASED
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07 
>   src/master/master.hpp ce0e0b3645b099d29c6d59312a91241379d5e80c 
>   src/master/master.cpp 53c8696fbe95792c40d7950a94c92f64c49ab892 
>   src/slave/http.cpp d03d36115384aa026de92be409fecc0e02b5a41e 
>   src/slave/slave.hpp 7b58cade9ada5f0a56b4c60c502eb907ccae33b4 
>   src/slave/slave.cpp a06d68032f26ccb3f786b6ea7c3a6c3c52449bd2 
>   src/tests/master_tests.cpp 3af20e9492ca38edd7a49b4e1f82c30880f53fa5 
>   src/tests/slave_tests.cpp a74ff7b914b6d68a8d1149a1b86426537f08deae 
> 
> Diff: https://reviews.apache.org/r/30296/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message