mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled.
Date Tue, 03 Mar 2015 18:17:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31250/#review74837
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/31250/#comment121896>

    s/opeation/operation/



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/31250/#comment121617>

    give it some memory too?



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/31250/#comment121619>

    Can you use Subprocess::PIPE here so the process will terminate if the parent exits?



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/31250/#comment121620>

    Is the earlier test for pids=[], tids=[] redundant?



src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/31250/#comment121890>

    s/Process/Process count/


- Ian Downes


On Feb. 23, 2015, 4:45 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31250/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 4:45 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: mesos-2103
>     https://issues.apache.org/jira/browse/mesos-2103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ian, as discussed, I put the logic in cpu isolator for now until linux launcher sees
more and more need to report isolator-independent cgroup usage.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 
>   src/slave/containerizer/isolators/cgroups/cpushare.cpp b6df23963f20e5f14f484d449733655d46cd6884

>   src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd 
> 
> Diff: https://reviews.apache.org/r/31250/diff/
> 
> 
> Testing
> -------
> 
> added a new test. the test is end-to-end so that future replacement of the actual logic
won't require a change.
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message