mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 31667: Piped hashmap<SlaveID, Resources> from allocator through to sorter.
Date Tue, 03 Mar 2015 09:09:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31667/#review74924
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31183, 31664, 31665, 31666, 31667]

All tests passed.

- Mesos ReviewBot


On March 3, 2015, 8:17 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31667/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 8:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Sorter` changes:
> 
> - Augmented `add`, `remove`, `allocated`, `unallocated`, `update` with `SlaveID`.
> - `allocation` returns `hashmap<SlaveID, Resources>`.
> 
> `DRFSorter` changes:
> 
> - `allocations` is updated from `hashmap<std::string, Resources>` to `hashmap<std::string,
hashmap<SlaveID, Resources>>`.
> - `resources` is updated from `Resources` to `hashmap<SlaveID, Resources>`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47

>   src/master/allocator/sorter/drf/sorter.hpp 4366710d6530b784aa5094813328d0e338239ba0

>   src/master/allocator/sorter/drf/sorter.cpp 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b

>   src/master/allocator/sorter/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b 
>   src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd 
> 
> Diff: https://reviews.apache.org/r/31667/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message