mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 31666: Piped hashmap<SlaveID, Resources> from master through to allocator.
Date Tue, 03 Mar 2015 08:12:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31666/#review74919
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31183, 31664, 31665, 31666]

All tests passed.

- Mesos ReviewBot


On March 3, 2015, 7:38 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31666/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 7:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Piped the master through by `s/sum(framework->usedResources.values())/framework->usedResources/`
> Lots of `s/Resources()/hashmap<SlaveID, Resources>()/` in `src/tests/hierarchical_allocator_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b 
>   src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f 
>   src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47

>   src/master/master.cpp dae0955d4ab29ea74ea5ab9dd6e19b028c58c6fd 
>   src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32

>   src/tests/mesos.hpp e91e5e484eea4587ac8f2eb9cefeab4acc9f4615 
> 
> Diff: https://reviews.apache.org/r/31666/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message