Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 971B010D08 for ; Fri, 27 Feb 2015 13:18:50 +0000 (UTC) Received: (qmail 90533 invoked by uid 500); 27 Feb 2015 13:18:47 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 90465 invoked by uid 500); 27 Feb 2015 13:18:47 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 90446 invoked by uid 99); 27 Feb 2015 13:18:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Feb 2015 13:18:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4FB851C0263; Fri, 27 Feb 2015 13:18:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7411279757767247674==" MIME-Version: 1.0 Subject: Re: Review Request 31183: Distinguished resources from different slaves in DRFSorter. From: "Alexander Rojas" To: "Alexander Rukletsov" , "Benjamin Hindman" , "Ben Mahler" , "Jie Yu" Cc: "Michael Park" , "Alexander Rojas" , "mesos" Date: Fri, 27 Feb 2015 13:18:46 -0000 Message-ID: <20150227131846.1420.79300@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rojas" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31183/ X-Sender: "Alexander Rojas" References: <20150225011631.4174.3187@reviews.apache.org> In-Reply-To: <20150225011631.4174.3187@reviews.apache.org> Reply-To: "Alexander Rojas" X-ReviewRequest-Repository: mesos --===============7411279757767247674== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31183/#review74482 ----------------------------------------------------------- include/mesos/resources.hpp Why not use `std::accumulate`? - Alexander Rojas On Feb. 25, 2015, 2:16 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31183/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 2:16 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Ben Mahler, and Jie Yu. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b > src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f > src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47 > src/master/allocator/sorter/drf/sorter.hpp 4366710d6530b784aa5094813328d0e338239ba0 > src/master/allocator/sorter/drf/sorter.cpp 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b > src/master/allocator/sorter/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b > src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07 > src/master/master.hpp d414061b1aa7b4cac6ab9a3cc14e8e028f9370d0 > src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93 > src/tests/hierarchical_allocator_tests.cpp 93753d1c04159a04a733927a487eb69505438e32 > src/tests/mesos.hpp 6b9656b2b858df75e725aaa042c447b755899c87 > src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd > > Diff: https://reviews.apache.org/r/31183/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > > --===============7411279757767247674==--