Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============7273742366439871411=="
MIME-Version: 1.0
Subject: Re: Review Request 31502: (1/4) Add fq_codel qdisc for egress
From: "Dominic Hamon" <dhamon@twopensource.com>
To: "Jie Yu" <yujie.jay@gmail.com>, "Ian Downes" <ian.downes@gmail.com>,
 "Chi Zhang" <chzhcn88@gmail.com>
Cc: "Dominic Hamon" <dhamon@twopensource.com>,
 "Cong Wang" <cwang@twopensource.com>, "mesos" <dev@mesos.apache.org>
Date: Thu, 26 Feb 2015 23:20:13 -0000
Message-ID: <20150226232013.1421.44774@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dominic Hamon" <noreply@reviews.apache.org>
References: <20150226231458.1420.4539@reviews.apache.org>
In-Reply-To: <20150226231458.1420.4539@reviews.apache.org>
Reply-To: "Dominic Hamon" <dhamon@twopensource.com>

--===============7273742366439871411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502/#review74393
-----------------------------------------------------------


please also add a jira reference to the bug field.

- Dominic Hamon


On Feb. 26, 2015, 3:14 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31502/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 3:14 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fq_codel qdisc is needed for egress flow classification. Internally fq_codel defines its own flows, and it allows us to specifiy the rule to classify the flows with tc filters attached on it. By default it has 1024 flows, much more than the number of containers we could create on a single host.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 17d0d7aa7361c3a373f6863d36b0a4767f5c05c4 
>   src/linux/routing/queueing/fq_codel.hpp PRE-CREATION 
>   src/linux/routing/queueing/fq_codel.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp 3cda6ab8c1ad24e4b7d0b9aeda2abc595fc857a5 
> 
> Diff: https://reviews.apache.org/r/31502/diff/
> 
> 
> Testing
> -------
> 
> Run the testcase.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


--===============7273742366439871411==--