Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8072889406956649887=="
MIME-Version: 1.0
Subject: Re: Review Request 31390: Added discovery info documentation.
From: "Christos Kozyrakis" <kozyraki@gmail.com>
To: "Niklas Nielsen" <nik@qni.dk>, "Connor Doyle" <connor@mesosphere.io>
Cc: "Christos Kozyrakis" <kozyraki@gmail.com>, "mesos" <dev@mesos.apache.org>
Date: Wed, 25 Feb 2015 05:35:03 -0000
Message-ID: <20150225053503.4174.48420@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Christos Kozyrakis" <noreply@reviews.apache.org>
References: <20150225031810.4174.45250@reviews.apache.org>
In-Reply-To: <20150225031810.4174.45250@reviews.apache.org>
Reply-To: "Christos Kozyrakis" <kozyraki@gmail.com>

--===============8072889406956649887==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 24, 2015, 7:18 p.m., Connor Doyle wrote:
> > docs/app-framework-development-guide.md, line 270
> > <https://reviews.apache.org/r/31390/diff/2/?file=874617#file874617line270>
> >
> >     Would you like to expand on the meaning of discoverability here?  For example, does this mean that other tasks started by the same scheduler should be able to discover this task?
> >     
> >     Similarly, since Mesos doesn't enforce any of the discoverability, should `is not` instead read `should not be`?

It will be very difficult to address this issue convincingly because it depends on the service discovery system, the networking setup, and whether Mesos allows you to inspect all running tasks through some endpoints etc. All we are doing here is providing info. What the service discovery system does with this info is largely undefined and out of scope. So for now I will change "is not" to "should not be".


- Christos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73969
-----------------------------------------------------------


On Feb. 24, 2015, 4:22 p.m., Christos Kozyrakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 4:22 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2396
>     https://issues.apache.org/jira/browse/MESOS-2396
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added discovery info documentation.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223 
> 
> Diff: https://reviews.apache.org/r/31390/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christos Kozyrakis
> 
>


--===============8072889406956649887==--