Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E710A102E1 for ; Tue, 24 Feb 2015 00:45:32 +0000 (UTC) Received: (qmail 56209 invoked by uid 500); 24 Feb 2015 00:45:32 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 56142 invoked by uid 500); 24 Feb 2015 00:45:32 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 56125 invoked by uid 99); 24 Feb 2015 00:45:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 00:45:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3A5B31D2EE8; Tue, 24 Feb 2015 00:45:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5157276596396764203==" MIME-Version: 1.0 Subject: Re: Review Request 31250: Expose the number of processes and threads in a container when cgroup is enabled. From: "Chi Zhang" To: "Ian Downes" Cc: "Mesos ReviewBot" , "Dominic Hamon" , "mesos" , "Chi Zhang" Date: Tue, 24 Feb 2015 00:45:30 -0000 Message-ID: <20150224004530.4175.92110@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chi Zhang" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31250/ X-Sender: "Chi Zhang" References: <20150221011212.21353.25679@reviews.apache.org> In-Reply-To: <20150221011212.21353.25679@reviews.apache.org> Reply-To: "Chi Zhang" X-ReviewRequest-Repository: mesos --===============5157276596396764203== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/ ----------------------------------------------------------- (Updated Feb. 24, 2015, 12:45 a.m.) Review request for mesos and Ian Downes. Changes ------- addressed comments. Bugs: mesos-2103 https://issues.apache.org/jira/browse/mesos-2103 Repository: mesos Description ------- Ian, as discussed, I put the logic in cpu isolator for now until linux launcher sees more and more need to report isolator-independent cgroup usage. Diffs (updated) ----- include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 src/slave/containerizer/isolators/cgroups/cpushare.cpp b6df23963f20e5f14f484d449733655d46cd6884 src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd Diff: https://reviews.apache.org/r/31250/diff/ Testing ------- added a new test. the test is end-to-end so that future replacement of the actual logic won't require a change. Thanks, Chi Zhang --===============5157276596396764203==--