Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 082C717ACB for ; Thu, 19 Feb 2015 04:14:15 +0000 (UTC) Received: (qmail 41738 invoked by uid 500); 19 Feb 2015 04:14:14 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 41673 invoked by uid 500); 19 Feb 2015 04:14:14 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 41654 invoked by uid 99); 19 Feb 2015 04:14:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Feb 2015 04:14:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1CE681D21F8; Thu, 19 Feb 2015 04:14:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0917475556681064332==" MIME-Version: 1.0 Subject: Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations. From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Vinod Kone" , "Adam B" , "Kapil Arya" Cc: "mesos" , "Till Toenshoff" , "Mesos ReviewBot" Date: Thu, 19 Feb 2015 04:14:13 -0000 Message-ID: <20150219041413.21354.28868@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27760/ X-Sender: "Mesos ReviewBot" References: <20150218035733.21354.86337@reviews.apache.org> In-Reply-To: <20150218035733.21354.86337@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============0917475556681064332== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73083 ----------------------------------------------------------- Patch looks great! Reviews applied: [27760] All tests passed. - Mesos ReviewBot On Feb. 18, 2015, 3:57 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27760/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 3:57 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2050 > https://issues.apache.org/jira/browse/MESOS-2050 > > > Repository: mesos > > > Description > ------- > > The initial design and implementation of the authenticator module interface caused issues and was not optimal for heavy lifting setup of external dependencies. By introducing a two fold design, this has been decoupled from the authentication message processing. The new design also gets us back on track to the goal of makeing SASL a soft dependency of mesos. > > > Diffs > ----- > > include/mesos/authentication/authenticator.hpp f66217a > src/Makefile.am d372404 > src/authentication/cram_md5/authenticator.hpp 7578ea1 > src/authentication/cram_md5/authenticator.cpp PRE-CREATION > src/authentication/cram_md5/auxprop.hpp d036b11 > src/authentication/cram_md5/auxprop.cpp 5ff9755 > src/master/master.hpp 6a39df0 > src/master/master.cpp f10a3cf > src/tests/cram_md5_authentication_tests.cpp dd102dc > > Diff: https://reviews.apache.org/r/27760/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > > --===============0917475556681064332==--