Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6C2E17A35 for ; Wed, 18 Feb 2015 08:42:04 +0000 (UTC) Received: (qmail 77119 invoked by uid 500); 18 Feb 2015 08:42:01 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 77058 invoked by uid 500); 18 Feb 2015 08:42:01 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 77041 invoked by uid 99); 18 Feb 2015 08:42:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 08:42:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 026B21C006B; Wed, 18 Feb 2015 08:42:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4357251585498318774==" MIME-Version: 1.0 Subject: Re: Review Request 31011: Changed comparison for CommandInfo to consider shell default value. From: "Mesos ReviewBot" To: "Till Toenshoff" Cc: "Mesos ReviewBot" , "Joerg Schad" , "mesos" Date: Wed, 18 Feb 2015 08:41:59 -0000 Message-ID: <20150218084159.21353.37222@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31011/ X-Sender: "Mesos ReviewBot" References: <20150217125824.21353.42679@reviews.apache.org> In-Reply-To: <20150217125824.21353.42679@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============4357251585498318774== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review72924 ----------------------------------------------------------- Patch looks great! Reviews applied: [31011] All tests passed. - Mesos ReviewBot On Feb. 17, 2015, 12:58 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31011/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 12:58 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > Changed comparison for CommandInfo to consider shell default value. > > > Diffs > ----- > > src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 > > Diff: https://reviews.apache.org/r/31011/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > > --===============4357251585498318774==--