Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53E4310B8B for ; Wed, 18 Feb 2015 00:01:24 +0000 (UTC) Received: (qmail 4874 invoked by uid 500); 18 Feb 2015 00:01:24 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 4808 invoked by uid 500); 18 Feb 2015 00:01:24 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 4790 invoked by uid 99); 18 Feb 2015 00:01:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Feb 2015 00:01:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 73D461D20E6; Wed, 18 Feb 2015 00:01:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3691281030492600103==" MIME-Version: 1.0 Subject: Re: Review Request 31024: Changed the slave logic so that it always waits for containerizer update to finish. From: "Jie Yu" To: "Vinod Kone" , "Ian Downes" Cc: "Jie Yu" , "mesos" Date: Wed, 18 Feb 2015 00:01:22 -0000 Message-ID: <20150218000122.21354.47683@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31024/ X-Sender: "Jie Yu" References: <20150217231917.21354.77139@reviews.apache.org> In-Reply-To: <20150217231917.21354.77139@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============3691281030492600103== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31024/ ----------------------------------------------------------- (Updated Feb. 18, 2015, 12:01 a.m.) Review request for mesos, Ian Downes and Vinod Kone. Changes ------- Rebased. Bugs: MESOS-998 https://issues.apache.org/jira/browse/MESOS-998 Repository: mesos Description ------- Changed the slave logic so that it always waits for containerizer update to finish. The key idea is to leverage `executor->queuedTasks` when containerizer->update is in progress. Diffs (updated) ----- include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 src/tests/master_tests.cpp e69a7fb39e93a9a999e0991985f5d060b72aac65 src/tests/registrar_zookeeper_tests.cpp 30d3cd8b1e7d56fbb326c9feccd4c3cbae2015de src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5 src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 Diff: https://reviews.apache.org/r/31024/diff/ Testing ------- make check Thanks, Jie Yu --===============3691281030492600103==--