Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3635310611 for ; Tue, 10 Feb 2015 11:19:12 +0000 (UTC) Received: (qmail 194 invoked by uid 500); 10 Feb 2015 11:19:12 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 121 invoked by uid 500); 10 Feb 2015 11:19:12 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 99996 invoked by uid 99); 10 Feb 2015 11:19:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 11:19:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 36A991CBF5D; Tue, 10 Feb 2015 11:19:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6879050348255959101==" MIME-Version: 1.0 Subject: Re: Review Request 30609: Added os::lstatsize(). From: "Bernd Mathiske" To: "Benjamin Hindman" , "Adam B" , "Timothy Chen" , "Till Toenshoff" Cc: "Isabel Jimenez" , "mesos" , "Bernd Mathiske" , "Mesos ReviewBot" , "Ian Downes" Date: Tue, 10 Feb 2015 11:19:11 -0000 Message-ID: <20150210111911.29076.62354@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bernd Mathiske" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30609/ X-Sender: "Bernd Mathiske" References: <20150207165912.1267.46284@reviews.apache.org> In-Reply-To: <20150207165912.1267.46284@reviews.apache.org> Reply-To: "Bernd Mathiske" X-ReviewRequest-Repository: mesos --===============6879050348255959101== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/ ----------------------------------------------------------- (Updated Feb. 10, 2015, 3:19 a.m.) Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen. Changes ------- Addressed Ian's review. Proposed name now: ownsize(). Bugs: MESOS-2072 https://issues.apache.org/jira/browse/MESOS-2072 Repository: mesos Description (updated) ------- This returns a file's size as reported by lstat(). (Not stat(). It is desired that in case of a link, the size of the link, not the size of the referenced file, is returned.) Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 8a4fda97ee29c185471a69f60803efc193cbe922 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16 Diff: https://reviews.apache.org/r/30609/diff/ Testing ------- Wrote a simple test that creates a file and tests its size, and also checks if a non-existing file yields an error. Thanks, Bernd Mathiske --===============6879050348255959101==--