Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 200C1100E2 for ; Tue, 10 Feb 2015 09:26:03 +0000 (UTC) Received: (qmail 50079 invoked by uid 500); 10 Feb 2015 09:26:03 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 50015 invoked by uid 500); 10 Feb 2015 09:26:03 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 49992 invoked by uid 99); 10 Feb 2015 09:26:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 09:26:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0C7911CBF5D; Tue, 10 Feb 2015 09:26:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8634711088919455036==" MIME-Version: 1.0 Subject: Re: Review Request 30774: Fetcher Cache From: "Adam B" To: "Benjamin Hindman" , "Adam B" , "Timothy Chen" , "Till Toenshoff" Cc: "mesos" , "Bernd Mathiske" Date: Tue, 10 Feb 2015 09:26:02 -0000 Message-ID: <20150210092602.29076.43378@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Adam B" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30774/ X-Sender: "Adam B" References: <20150210091437.11124.24676@reviews.apache.org> In-Reply-To: <20150210091437.11124.24676@reviews.apache.org> Reply-To: "Adam B" X-ReviewRequest-Repository: mesos --===============8634711088919455036== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review71770 ----------------------------------------------------------- Please update the description with a descriptive commit message. Also explain any testing you did for HDFS fetching (since it's half-broken without the HADOOP_HOME fix). - Adam B On Feb. 10, 2015, 1:14 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30774/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 1:14 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2057, MESOS-2069, MESOS-2070, MESOS-2072, and MESOS-2074 > https://issues.apache.org/jira/browse/MESOS-2057 > https://issues.apache.org/jira/browse/MESOS-2069 > https://issues.apache.org/jira/browse/MESOS-2070 > https://issues.apache.org/jira/browse/MESOS-2072 > https://issues.apache.org/jira/browse/MESOS-2074 > > > Repository: mesos > > > Description > ------- > > Replaces all other reviews for the fetcher cache except those related to stout: 30006, 30033, 30034, 30036, 30037, 30039, 30124, 30173, 30614, 30616, 30618, 30621, 30626. See descriptions of those. > > > Diffs > ----- > > include/mesos/fetcher/fetcher.proto facb87b92bf3194516f636dcc348e136af537721 > include/mesos/mesos.proto 3a2921dff856d37455593dcbf7340aa537997d35 > src/Makefile.am 0fe4809542a7d23785a221901947771320b43d52 > src/hdfs/hdfs.hpp 968545d9af896f3e72e156484cc58135405cef6b > src/launcher/fetcher.cpp 5b2d86d1867b25bf71461fd73df91b089002325b > src/slave/constants.hpp 7717abd4f9a3bd6fdca6af2364864e374ce2e056 > src/slave/containerizer/docker.hpp 70114dcef7a416ae904e95eb9ce365bcd866aebc > src/slave/containerizer/docker.cpp 813ddf8c98622748b2da1b739bf122387abc4c79 > src/slave/containerizer/fetcher.hpp bfd98dbe16e2bd5df3e2c8e9b10e303654f33446 > src/slave/containerizer/fetcher.cpp 6e6bce08d76bb8a5813c905e3ffeff9b2411fd6d > src/slave/containerizer/mesos/containerizer.hpp b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d > src/slave/containerizer/mesos/containerizer.cpp fa40d47aee7803833bcde6cce1e86a21d7cf27d0 > src/slave/flags.hpp f6033355d129f0013d39dd053455c936596bf159 > src/slave/slave.cpp fff2d725fe49eee984d9151cfb2131202c47994f > src/tests/docker_containerizer_tests.cpp 8b212d4e6ed5a179ebadce1bdbbf3edde87d706c > src/tests/fetcher_cache_tests.cpp PRE-CREATION > src/tests/fetcher_tests.cpp fcbf7ad912f0b1b3d106a75a9dcb8213a0c69c07 > src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190 > src/tests/mesos.cpp 21a405366f56c963611324076efe775f85b9d9f7 > src/tests/mock_hadoop.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/30774/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bernd Mathiske > > --===============8634711088919455036==--