Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0190910C0C for ; Mon, 9 Feb 2015 16:34:49 +0000 (UTC) Received: (qmail 10762 invoked by uid 500); 9 Feb 2015 16:34:48 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 10694 invoked by uid 500); 9 Feb 2015 16:34:48 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 10676 invoked by uid 99); 9 Feb 2015 16:34:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 16:34:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C591C1CE09E; Mon, 9 Feb 2015 16:34:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6898166800133647589==" MIME-Version: 1.0 Subject: Re: Review Request 29883: Added /master/slaves endpoint. From: "Till Toenshoff" To: "Niklas Nielsen" , "Till Toenshoff" , "Ben Mahler" Cc: "Alexander Rojas" , "mesos" Date: Mon, 09 Feb 2015 16:34:47 -0000 Message-ID: <20150209163447.29075.9278@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29883/ X-Sender: "Till Toenshoff" References: <20150204103749.1285.22831@reviews.apache.org> In-Reply-To: <20150204103749.1285.22831@reviews.apache.org> Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos --===============6898166800133647589== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29883/#review71639 ----------------------------------------------------------- Ship it! src/master/http.cpp I am not sure about this description. 200 is expected given that this is not a conditional check (like e.g. health). Or are we not getting a 200 in any case? How about "This endpoint receives information indicating registered slave(s)." - Till Toenshoff On Feb. 4, 2015, 10:37 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29883/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 10:37 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/slaves. > > Works in conjunction with [30612](https://reviews.apache.org/r/30612). > > Builds on the abandoned patch 14286. > > Old description: this is WIP that bmahler wants to take on. > > > Diffs > ----- > > src/master/http.cpp 3981b18 > src/master/master.hpp 337e00a > src/master/master.cpp 1005686 > src/tests/master_tests.cpp 678d27f > > Diff: https://reviews.apache.org/r/29883/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > > --===============6898166800133647589==--