Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7281B175A7 for ; Sun, 8 Feb 2015 09:24:35 +0000 (UTC) Received: (qmail 94015 invoked by uid 500); 8 Feb 2015 09:24:35 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 93917 invoked by uid 500); 8 Feb 2015 09:24:35 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 970 invoked by uid 99); 6 Feb 2015 23:22:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Feb 2015 23:22:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A8C7B1CDD47; Fri, 6 Feb 2015 23:22:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1448345882802630481==" MIME-Version: 1.0 Subject: Re: Review Request 27531: Update Master metrics to match task source and reason scheme. From: "Dominic Hamon" To: "Vinod Kone" Cc: "Mesos ReviewBot" , "mesos" , "Dominic Hamon" Date: Fri, 06 Feb 2015 23:22:50 -0000 Message-ID: <20150206232250.1286.71080@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dominic Hamon" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/27531/ X-Sender: "Dominic Hamon" References: <20150206184211.1285.93183@reviews.apache.org> In-Reply-To: <20150206184211.1285.93183@reviews.apache.org> Reply-To: "Dominic Hamon" X-ReviewRequest-Repository: mesos --===============1448345882802630481== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27531/ ----------------------------------------------------------- (Updated Feb. 6, 2015, 3:22 p.m.) Review request for mesos and Vinod Kone. Changes ------- consolidated metric updates somewhat. some exceptions where TODOs exist to use 'forward'. Bugs: MESOS-1830 https://issues.apache.org/jira/browse/MESOS-1830 Repository: mesos Description ------- Update metrics in Master to match the source and reason split for task statuses. Diffs (updated) ----- src/master/master.hpp c3c77f840f089c5754c764e7f150a3c1971d311f src/master/master.cpp 22fece79c6e511a1b61eb674d7f82216e7a25e00 src/master/metrics.hpp ee8b5bc76336ece9192455b216187482cee29420 src/master/metrics.cpp 0b3b91e744cdb76cd843edfcf34b12b842fcb06e src/slave/slave.hpp 9adee17cb94a72f0e1e139b3fd8978a9a1ff6237 src/slave/slave.cpp 336e8776be656c5e6ad1b0d997f54c307f4559f8 src/tests/master_authorization_tests.cpp 6fd0efa444dce5203e2e755d4de0483fcaa277f8 src/tests/master_slave_reconciliation_tests.cpp 09742855c9fcd6bd10ab79af582b14fba2e6b609 src/tests/master_tests.cpp 62ba35b9c3f999c59a95bffb01b8b82cc543a34f src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190 src/tests/mesos.cpp 21a405366f56c963611324076efe775f85b9d9f7 src/tests/rate_limiting_tests.cpp 8b55bffff0b7713806fc0bcc63d8a7097a8408e0 src/tests/slave_tests.cpp 68a6498cd86723e571b262b2495b4b504e744428 Diff: https://reviews.apache.org/r/27531/diff/ Testing ------- added metric tests to master tests make check Thanks, Dominic Hamon --===============1448345882802630481==--