Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EB59178A3 for ; Wed, 4 Feb 2015 20:40:04 +0000 (UTC) Received: (qmail 50370 invoked by uid 500); 4 Feb 2015 20:40:05 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 50307 invoked by uid 500); 4 Feb 2015 20:40:05 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 50291 invoked by uid 99); 4 Feb 2015 20:40:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 20:40:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4C00D1CC407; Wed, 4 Feb 2015 20:40:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0049085954719791128==" MIME-Version: 1.0 Subject: Re: Review Request 30635: Fixed MESOS-2319 by creating the temporary file under the same base directory. From: "Jie Yu" To: "Michael Park" , "Ben Mahler" , "Vinod Kone" Cc: "Jie Yu" , "mesos" Date: Wed, 04 Feb 2015 20:40:00 -0000 Message-ID: <20150204204000.1285.19082@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30635/ X-Sender: "Jie Yu" References: <20150204203105.1285.70689@reviews.apache.org> In-Reply-To: <20150204203105.1285.70689@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============0049085954719791128== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 4, 2015, 8:31 p.m., Ben Mahler wrote: > > Is there a test of this function? > > > > Might be nice to add a NOTE or TODO about how to address the issue of leaving dangling files when we failover at the wrong time? Yes, SlaveStateTest should catch the regression. Will add a NOTE, the dangline file will most likely be GCed with the directory since we cannot recover the task/executor. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30635/#review71035 ----------------------------------------------------------- On Feb. 4, 2015, 7:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30635/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:38 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Bugs: MESOS-2319 > https://issues.apache.org/jira/browse/MESOS-2319 > > > Repository: mesos > > > Description > ------- > > Fixed MESOS-2319 by creating the temporary file under the same base directory. > > > Diffs > ----- > > src/slave/state.hpp de631fb2c8a8d2bcbb861c438b18141ba6211024 > > Diff: https://reviews.apache.org/r/30635/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============0049085954719791128==--