Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B565817369 for ; Wed, 4 Feb 2015 13:45:27 +0000 (UTC) Received: (qmail 12416 invoked by uid 500); 4 Feb 2015 13:45:28 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 12348 invoked by uid 500); 4 Feb 2015 13:45:28 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 12331 invoked by uid 99); 4 Feb 2015 13:45:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 13:45:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0948F1CC153; Wed, 4 Feb 2015 13:45:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5947551943528250020==" MIME-Version: 1.0 Subject: Re: Review Request 30601: Updated slave to use Executor/Task grace period, with a maximum. From: "Alexander Rukletsov" To: "Alexander Rukletsov" , "Niklas Nielsen" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 04 Feb 2015 13:45:24 -0000 Message-ID: <20150204134524.1286.64193@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/30601/ X-Sender: "Alexander Rukletsov" References: <20150204021441.32500.952@reviews.apache.org> In-Reply-To: <20150204021441.32500.952@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============5947551943528250020== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30601/#review70960 ----------------------------------------------------------- This patch (together with the previous one) actually fixes https://issues.apache.org/jira/browse/MESOS-1773 : ). src/tests/slave_tests.cpp // Create a task with shutdown grace period set explicitly. - Alexander Rukletsov On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30601/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:14 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2228 > https://issues.apache.org/jira/browse/MESOS-2228 > > > Repository: mesos > > > Description > ------- > > Now the slave doesn't completely ignore the grace period, note that there is a bound of 1 minute for now. > > > Diffs > ----- > > include/mesos/mesos.proto 28612168c66d85679b35d743e96954770f37daec > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 > src/slave/containerizer/containerizer.cpp 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30601/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > > --===============5947551943528250020==--