mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Rukletsov <a...@mesosphere.io>
Subject Re: Review Request 31416: Remove extra semicolons.
Date Sat, 28 Feb 2015 21:24:20 GMT
A very good point, Ben. I think it makes sense to document it somewhere. I
believe you plan to create a doc for contributors, would you put it there?

Alex
On 27/02/2015 10:11 pm, "Benjamin Mahler" <benjamin.mahler@gmail.com> wrote:

> Did we really need to have 3 people and 6 emails to remove some double
> semi-colons?
>
> I'd highly encourage us to try to avoid the pattern of "drive-by"
> reviewing when you see something that looks "easy" and want to jump in.
> We've historically found this pattern to be very distracting and
> counter-productive. There are a ton of reviews in the community that
> languish because they require more thorough attention, and I would love to
> see others pitching in on these. IMHO that's where a ton of value can be
> added. It's also a great way to force yourself to read and understand more
> parts of the code and do things that the community values.
>
> Always feel free to reach out to ask other committers and contributors
> about where you'd like to do some reviewing. A few of the committers talked
> briefly about "shadow" reviewing (where you review with the help of a
> shepherd), which might be a great way to start.
>
> On Fri, Feb 27, 2015 at 12:52 PM, Ben Mahler <benjamin.mahler@gmail.com>
> wrote:
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/31416/#review74579
>> -----------------------------------------------------------
>>
>> Ship it!
>>
>>
>> Does the style checker pick these up?
>>
>> - Ben Mahler
>>
>>
>> On Feb. 25, 2015, 5:08 p.m., Alexander Rukletsov wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/31416/
>> > -----------------------------------------------------------
>> >
>> > (Updated Feb. 25, 2015, 5:08 p.m.)
>> >
>> >
>> > Review request for mesos, Benjamin Hindman and Ben Mahler.
>> >
>> >
>> > Repository: mesos
>> >
>> >
>> > Description
>> > -------
>> >
>> > See summary.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> >   src/exec/exec.cpp a159846d03f6ee6f7722c7e1ac2cccfb79d05a7d
>> >   src/slave/containerizer/isolators/cgroups/cpushare.cpp
>> b6df23963f20e5f14f484d449733655d46cd6884
>> >   src/slave/slave.cpp e52ff5a1feb9006bfa8b6dfa6266126114dfbdff
>> >   src/tests/reconciliation_tests.cpp
>> b79f85ec4d279375dc369bb3c2932aa82d8220f1
>> >
>> > Diff: https://reviews.apache.org/r/31416/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> > make check (Mac OS 10.9.5)
>> >
>> >
>> > Thanks,
>> >
>> > Alexander Rukletsov
>> >
>> >
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message