mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 31514: Improved slave removal rate limiting tests.
Date Fri, 27 Feb 2015 20:28:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31514/#review74574
-----------------------------------------------------------

Ship it!


thanks for fixing the tests!


src/tests/slave_tests.cpp
<https://reviews.apache.org/r/31514/#comment121181>

    Without settling the clock, are we guaranteed that shutdown() event will be processed?



src/tests/slave_tests.cpp
<https://reviews.apache.org/r/31514/#comment121190>

    ditto. need Clock::settle?


- Vinod Kone


On Feb. 27, 2015, 2:58 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31514/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 2:58 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SlaveTest.RateLimitSlaveShutdown now ensures that no shutdown is sent before the rate
limiting permit is satisfied.
> SlaveTest.CancelSlaveShutdown now only needs to use 1 slave to test that cancellation
works.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 30c56fc4f46345f8f3c076211e8b4704a59ff28a 
>   src/tests/limiter.hpp PRE-CREATION 
>   src/tests/mesos.hpp 6b9656b2b858df75e725aaa042c447b755899c87 
>   src/tests/mesos.cpp df051d9f647ed716f06055c312f18d8d1759a437 
>   src/tests/slave_tests.cpp 7ea012ab0883cc030b3e62f59879613866dab0fa 
> 
> Diff: https://reviews.apache.org/r/31514/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests with 500 iterations.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message