mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 30014: Enable the slave garbage collector to take the number of links into account.
Date Fri, 27 Feb 2015 15:06:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30014/#review74498
-----------------------------------------------------------


I would like to propose to create have a clear definition of the problem and of the intended
approach before jumping into a specific implementation. I have added a comment to MESOS-391
to keep the discussion there, where it belongs for now, IMHO. 

Furthermore, I would like to see a test that reproduces the behavior in question. Normally
it would be OK to provide the test after the initial implementation (but still before everything
is committed). But in this case, it seems better to me to have a test that reproduces the
problem, first, and then confirm that this is intended the problem to solve. 

At least I am not sure about the exact nature of the problem yet and so I would to see either
more explanations based on system manuals or more evidence from testing or both.

- Bernd Mathiske


On Jan. 22, 2015, 1:35 p.m., Ritwik Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30014/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 1:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone.
> 
> 
> Bugs: MESOS-391
>     https://issues.apache.org/jira/browse/MESOS-391
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A fix to enable the slave garbage collector to take the number of hard links (st_nlinks)
into account when creating new directories.
> 
> [UPDATE] - Distributed the changes into two review requests as per information posted
by the Mesos ReviewBot.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 
>   src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 
>   src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 
>   src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 
> 
> Diff: https://reviews.apache.org/r/30014/diff/
> 
> 
> Testing
> -------
> 
> Mesos builds sucessfully and all existing tests pass.
> 
> 
> Thanks,
> 
> Ritwik Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message