mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29290: mesos: Extend the IP and IPNetwork classes to support IPv6.
Date Fri, 27 Feb 2015 06:54:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 6:54 a.m.)


Review request for .


Bugs: MESOS-1919
    https://issues.apache.org/jira/browse/MESOS-1919


Repository: mesos


Description
-------

Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but
write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp a5793918a2c1bc1c13432653c4219de7283fefd1 
  src/common/protobuf_utils.cpp f57213a5ab33787296d17abccfca71345a90d9a4 
  src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff 
  src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d 
  src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 
  src/linux/routing/route.hpp 9e5339192aeb5e26b932a54e7b9110430eafbd9b 
  src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d 
  src/master/http.cpp 117c0ee720a60a1d8a25359028bad803f1fc2b07 
  src/master/master.cpp 76e217d16c03e587ea4c0afca94c58b2212f0f93 
  src/sched/sched.cpp 0f857032a4b38a73f2dcd7e069e9f97a0941847b 
  src/scheduler/scheduler.cpp 5ae27960c6a4e05ce48eb9d8c8f3390183e74f46 
  src/slave/containerizer/isolators/network/port_mapping.hpp 8443097b2c79fef5ae0e23a3fb815ffec0318a93

  src/slave/containerizer/isolators/network/port_mapping.cpp 5227987cdb7b904c2f4bb2bdf5c5d705a435010d

  src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9 
  src/tests/master_contender_detector_tests.cpp f8c7f2cf81aa8376ab0da545270406300a385ba6 
  src/tests/master_tests.cpp 5692f072a7bfa0b795c5996a6b809f2246bb6a66 
  src/tests/port_mapping_tests.cpp e2c8ba12b5574b06a6ba60c3c3a30b63cea1d23c 

Diff: https://reviews.apache.org/r/29290/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message