mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 31472: stout: Make fromLinkDevice method member of the IPNetwork class.
Date Thu, 26 Feb 2015 18:52:39 GMT


> On Feb. 26, 2015, 6:47 p.m., Dominic Hamon wrote:
> > i don't see the change to the actual method here..
> 
> Evelina Dumitrescu wrote:
>     The changes are in the fromLinkDevice test 
>     ie:  net::IPNetwork::fromLinkDevice(link, AF_INET); instead of  net::fromLinkDevice(link,
AF_INET);
> 
> Dominic Hamon wrote:
>     this review should also have the change in ip.hpp shouldn't they?

yes, they should.


- Evelina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review74320
-----------------------------------------------------------


On Feb. 26, 2015, 6:41 a.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31472/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 6:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere,
and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8

> 
> Diff: https://reviews.apache.org/r/31472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message