mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 31489: Fix use of buffers in OS to remove leaks.
Date Thu, 26 Feb 2015 18:17:42 GMT


> On Feb. 26, 2015, 6:14 p.m., Ben Mahler wrote:
> > This is pretty inconsistent with the rest of our code. Why can't you add the missing
deletes?
> 
> Dominic Hamon wrote:
>     we can. but why not start getting rid of the archaic practice of using raw pointers?

I agree having less prone to errors is more desired.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31489/#review74305
-----------------------------------------------------------


On Feb. 26, 2015, 6:14 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31489/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 6:14 p.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Bugs: MESOS-2412
>     https://issues.apache.org/jira/browse/MESOS-2412
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix use of buffers in OS to remove leaks.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 8a4fda97ee29c185471a69f60803efc193cbe922

> 
> Diff: https://reviews.apache.org/r/31489/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message