mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 31480: Fix check for lseek error.
Date Thu, 26 Feb 2015 13:30:36 GMT


> On Feb. 26, 2015, 8:05 a.m., Kapil Arya wrote:
> > src/slave/state.cpp, line 621
> > <https://reviews.apache.org/r/31480/diff/1/?file=878304#file878304line621>
> >
> >     Should we also add strerror(errno) to inform about the lseek error?

Just realized that it's using ErrnoError :-).


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31480/#review74264
-----------------------------------------------------------


On Feb. 26, 2015, 4:10 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31480/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 4:10 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix check for lseek error.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.cpp 0329ba56367a89e3ac5b1f3fcc3e3315ccd33999 
> 
> Diff: https://reviews.apache.org/r/31480/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message