mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 31362: Reenabled hadoop_home and frameworks_home slave flags for mesos-fetcher and added tests
Date Thu, 26 Feb 2015 08:16:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31362/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 12:16 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Changes
-------

Now inlining the mock hadoop script. This avoids dealing with the apparently unusable flags.source_dir.


Bugs: MESOS-2390
    https://issues.apache.org/jira/browse/MESOS-2390


Repository: mesos


Description
-------

Now the containerizer/fetcher sets the HADOOP_HOME variable for mesos-fetcher again if the
slave flag hadoop_home is set. Added a test that checks that HDFS fetching is not broken and
also ensures that the flag gets translated to the environment variable and then gets applied
in mesos-fetcher. Created a mock hadoop implementation script for this. This script has the
exact same side effects as a real haddop client in the scope of our testing. Using this, Mesos
testing has no extra external dependencies (on Hadoop).

Slave flag frameworks_home does not need to be an evironment variable. It is now part of FetcherInfo
only, but it also gets tested now that it works.


Diffs (updated)
-----

  include/mesos/fetcher/fetcher.proto facb87b92bf3194516f636dcc348e136af537721 
  src/launcher/fetcher.cpp fed0105946da579a38357a30e7ae56e646e05b89 
  src/slave/containerizer/fetcher.cpp d290f95251def3952c5ee34f600e1d71467f6293 
  src/tests/fetcher_tests.cpp 2438620e2db94c3c56336fa5d8e69a18fe8f3bac 

Diff: https://reviews.apache.org/r/31362/diff/


Testing
-------

make check


Thanks,

Bernd Mathiske


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message