mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 29289: libprocess: Extend the IP and IPNetwork classes to support IPv6.
Date Thu, 26 Feb 2015 06:44:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 6:44 a.m.)


Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and
Niklas Nielsen.


Summary (updated)
-----------------

libprocess: Extend the IP and IPNetwork classes to support IPv6.


Bugs: MESOS-1919
    https://issues.apache.org/jira/browse/MESOS-1919


Repository: mesos


Description
-------

Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but
write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing
of the protocol headers differ.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368 
  3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3

  3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272

  3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e 
  3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881

  3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915 
  3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd 
  3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656 
  3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2 
  3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 
  3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7 
  3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257


Diff: https://reviews.apache.org/r/29289/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message