mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 30850: Added validation for checkpointed resources during slave recovery.
Date Wed, 25 Feb 2015 18:43:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30850/#review74044
-----------------------------------------------------------

Ship it!



include/mesos/resources.hpp
<https://reviews.apache.org/r/30850/#comment120531>

    Checkpointing seems like a mesos implementation detail, any reason you want it in resources.hpp?
What about creating a resource_utils.hpp or moving it to protobuf_utils.hpp with a TODO?



include/mesos/resources.hpp
<https://reviews.apache.org/r/30850/#comment120532>

    Ditto here, let's try not to leak mesos implementation into resources.hpp. Can you move
this out for now (maybe protobuf_utils.hpp as a placeholder?).



src/slave/slave.cpp
<https://reviews.apache.org/r/30850/#comment120539>

    Can you comment on the None() case here? Is it when we simply don't have any checkpointed
resources?



src/slave/slave.cpp
<https://reviews.apache.org/r/30850/#comment120541>

    Could we call this something like `applyCheckpointedResources`?


- Ben Mahler


On Feb. 25, 2015, 5:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30850/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for checkpointed resources during slave recovery.
> 
> This is a rebased version for https://reviews.apache.org/r/29913/
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 
>   src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 
>   src/master/master.hpp d414061b1aa7b4cac6ab9a3cc14e8e028f9370d0 
>   src/slave/slave.hpp f3eab7ed7f9b098e46405464f922c7f2165822b4 
>   src/slave/slave.cpp e52ff5a1feb9006bfa8b6dfa6266126114dfbdff 
>   src/tests/mesos.hpp 6b9656b2b858df75e725aaa042c447b755899c87 
>   src/tests/mesos.cpp df051d9f647ed716f06055c312f18d8d1759a437 
>   src/tests/persistent_volume_tests.cpp 2b67370c34d521d157f2f22c2de9f684a0b5446c 
> 
> Diff: https://reviews.apache.org/r/30850/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message