mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 31337: Created a TestLauncher that mocks Launcher.
Date Tue, 24 Feb 2015 20:07:45 GMT


> On Feb. 24, 2015, 5:33 p.m., Jie Yu wrote:
> > src/tests/launcher.hpp, lines 71-72
> > <https://reviews.apache.org/r/31337/diff/1/?file=873421#file873421line71>
> >
> >     Move this to the top?
> 
> Vinod Kone wrote:
>     Don't want to pollute the namespace with using directive in header files.

oops, my bad. Not realized that this is a header.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31337/#review73833
-----------------------------------------------------------


On Feb. 24, 2015, 8:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31337/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 8:03 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-1690
>     https://issues.apache.org/jira/browse/MESOS-1690
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed for subsequent review.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 65cba64834d8d2224761105516c64c6ba203f9f3 
>   src/tests/launcher.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31337/diff/
> 
> 
> Testing
> -------
> 
> Tested in subsequent review.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message